chore: lint tests

[faddat]

Description

An earlier PR did not actually lint tests. This PR actually ensures that test code is linted and consistent. The first PR had two things masking the linting of test files and I'd only disabled one.

---

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Targeted PR against the correct branch
• included the correct type prefix in the PR title
• Linked to the GitHub issue with discussion and accepted design
• Targets only one GitHub issue
• Wrote unit and integration tests
• Wrote relevant migration scripts if necessary
• All CI checks have passed
• Added relevant godoc comments
• Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
• Add an issue in the e2e-tests repo if necessary

SDK Checklist

• Import/Export Genesis
• Registered Invariants
• Registered Events
• Updated openapi.yaml
• No usage of go map
• No usage of time.Now()
• Used fixed point arithmetic and not float arithmetic
• Avoid panicking in Begin/End block as much as possible
• No unexpected math Overflow
• Used sendCoin and not SendCoins
• Out-of-block compute is bounded
• No serialized ID at the end of store keys
• UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

• Confirmed the correct type prefix in the PR title
• Reviewers assigned
• Confirmed all author checklist items have been addressed

---;

After reviewer approval:

• In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
• In case the PR targets a release branch, PR must be rebased.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.62%. Comparing base (079417d) to head (7d20ef5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   30.62%   30.62%           
=======================================
  Files         227      227           
  Lines       32024    32024           
=======================================
  Hits         9807     9807           
  Misses      20656    20656           
  Partials     1561     1561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[omritoptix]

@faddat linter is still failing

[faddat]

@omritoptix - indeed, I'm having a proper "works on my computer" situation rn

Turned out to be one of the starport configuration lines. Does the project still use starport / ignite?

[faddat]

@mtsitrin please hang on a moment before merging this.

• https://github.com/dymensionxyz/dymension/actions/runs/8327179536/job/22784308756?pr=685#step:5:263

[faddat]

theory: in the tests there's a double registered proto. When I added error checks, this gave it a chance to give output. Theory could be wrong.

https://github.com/dymensionxyz/dymension/actions/runs/8327179536/job/22784308756?pr=685#step:5:32

[faddat]

Ah, luckily, it seems to have resolved :).