Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialized the settlement client with the proposer upon initialization #168

Merged
merged 6 commits into from
Dec 26, 2022

Conversation

omritoptix
Copy link
Contributor

and refactored the settlement client to be more testable.

@omritoptix omritoptix requested a review from a team as a code owner December 25, 2022 17:05
mtsitrin
mtsitrin previously approved these changes Dec 25, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #168 (9c44d15) into main (8ec3b08) will decrease coverage by 1.55%.
The diff coverage is 27.65%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   55.02%   53.46%   -1.56%     
==========================================
  Files          60       66       +6     
  Lines       11014    11793     +779     
==========================================
+ Hits         6060     6305     +245     
- Misses       4083     4584     +501     
- Partials      871      904      +33     
Impacted Files Coverage Δ
settlement/dymension/cosmosclient.go 0.00% <0.00%> (ø)
settlement/events.go 100.00% <ø> (ø)
settlement/settlement.go 0.00% <0.00%> (ø)
mocks/settlement/rollapp_query_client.go 2.22% <2.22%> (ø)
mocks/settlement/sequencer_query_client.go 12.06% <12.06%> (ø)
mocks/cosmosclient.go 18.96% <18.96%> (ø)
settlement/dymension/dymension.go 22.26% <22.26%> (ø)
mocks/settlement/hubclient.go 34.04% <34.04%> (ø)
settlement/mock/mock.go 70.11% <75.47%> (+8.84%) ⬆️
settlement/base.go 78.03% <78.03%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix merged commit c9cfddf into main Dec 26, 2022
@omritoptix omritoptix deleted the omritoptix/156-set-active-sequencer branch December 26, 2022 10:10
@omritoptix omritoptix linked an issue Dec 26, 2022 that may be closed by this pull request
@omritoptix omritoptix linked an issue Jan 10, 2023 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the active sequencer from the hub upon initialization gossip blocks
3 participants