Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gossip): validate blocks when receiving them over gossip #699

Merged
merged 27 commits into from
Apr 18, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 16, 2024

PR Standards

Opening a pull request should be able to meet the following requirements


Close #656

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt marked this pull request as ready for review April 17, 2024 10:28
@danwt danwt requested a review from a team as a code owner April 17, 2024 10:28
block/manager.go Show resolved Hide resolved
block/retriever.go Outdated Show resolved Hide resolved
block/executor.go Outdated Show resolved Hide resolved
@danwt danwt requested a review from mtsitrin April 18, 2024 09:52
mtsitrin
mtsitrin previously approved these changes Apr 18, 2024
@danwt
Copy link
Contributor Author

danwt commented Apr 18, 2024

it looks like some autorefactor used a types2 name, I'll fix it

@mtsitrin mtsitrin merged commit 18f98d2 into main Apr 18, 2024
4 checks passed
@mtsitrin mtsitrin deleted the danwt/656-no-not-receive-invalid-blocks-from-gossip branch April 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid blocks can be received via p2p gossip
2 participants