Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE Order factories - handle variations #56

Merged
merged 4 commits into from
Jul 15, 2020

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jul 10, 2020

BUGFIX - OrderDetailFactory - handle setting product id if Code is from a variation

closes #55

BUGFIX - OrderDetailFactory - handle setting product id if Code is from a variation

closes dynamic#55
@jsirish jsirish requested a review from muskie9 July 10, 2020 22:17
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #56 into 1.0 will decrease coverage by 4.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.0      #56      +/-   ##
============================================
- Coverage     22.89%   18.62%   -4.27%     
- Complexity       56       71      +15     
============================================
  Files            10       11       +1     
  Lines           166      204      +38     
============================================
  Hits             38       38              
- Misses          128      166      +38     
Flag Coverage Δ Complexity Δ
#php 18.62% <0.00%> (-4.27%) 71.00 <14.00> (+15.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Factory/OrderDetailFactory.php 0.00% <0.00%> (ø) 9.00 <0.00> (+1.00)
src/Factory/OrderFactory.php 0.00% <0.00%> (ø) 10.00 <0.00> (ø)
src/Factory/OrderVariationFactory.php 0.00% <0.00%> (ø) 14.00 <14.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659bc38...67743cf. Read the comment docs.

@jsirish jsirish merged commit 07a0786 into dynamic:1.0 Jul 15, 2020
@jsirish jsirish deleted the feature/variationFactory branch July 15, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG OrderDetailFactory - check if Code belongs to a Variation
1 participant