Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 0 values defaulting to being user editable #88

Merged
merged 7 commits into from
Jul 14, 2020

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Mar 5, 2020

Added link generator
Added doc blocks
Updated quantity field

  • store now calls correctly to website

Resolves #87

mak001 and others added 2 commits March 5, 2020 15:08
Added link generator
Added doc blocks
Updated quantity field
  - store now calls correctly to website
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #88 into 1.2 will decrease coverage by 1.62%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.2      #88      +/-   ##
============================================
- Coverage     62.51%   60.89%   -1.63%     
- Complexity      204      214      +10     
============================================
  Files            11       12       +1     
  Lines           763      785      +22     
============================================
+ Hits            477      478       +1     
- Misses          286      307      +21     
Flag Coverage Δ Complexity Δ
#php 60.89% <0.00%> (-1.63%) 214.00 <8.00> (+10.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Controller/FoxyLinkGeneratorController.php 0.00% <0.00%> (ø) 8.00 <8.00> (?)
src/Extension/Shippable.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Form/QuantityField.php 0.00% <0.00%> (ø) 6.00 <0.00> (+1.00)
src/Form/AddToCartForm.php 65.00% <0.00%> (-0.22%) 38.00% <0.00%> (+1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0dc5c...64efccf. Read the comment docs.

@mak001 mak001 changed the base branch from 1.0 to 1.2 July 14, 2020 13:50
@mak001 mak001 merged commit 6d4ef77 into dynamic:1.2 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - values of 0 fail to hash properly due to being considered 'open' fields
1 participant