Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fuller support for resolving anonymous type data on a dynamic object #258

Merged
merged 6 commits into from
Sep 26, 2022

Conversation

holdenmai
Copy link
Contributor

Issue #93

The major change made with this is that rather than performing the binding, somewhat greedily, on typeof(object), we leverage the actual instance present in the CallSiteBinder args parameter to get the actual type as late as possible.

Copy link
Contributor

@metoule metoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor nitpicking comments, but otherwise it looks good to me, thanks a lot!

test/DynamicExpresso.UnitTest/DynamicTest.cs Outdated Show resolved Hide resolved
test/DynamicExpresso.UnitTest/DynamicTest.cs Outdated Show resolved Hide resolved
src/DynamicExpresso.Core/Parsing/Parser.cs Show resolved Hide resolved
src/DynamicExpresso.Core/Parsing/Parser.cs Outdated Show resolved Hide resolved
src/DynamicExpresso.Core/Parsing/Parser.cs Outdated Show resolved Hide resolved
src/DynamicExpresso.Core/Parsing/Parser.cs Outdated Show resolved Hide resolved
@metoule
Copy link
Contributor

metoule commented Sep 21, 2022

LGTM, thanks again for all your contributions!
@davideicardi I'll let you have a look as well :)

Copy link
Member

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice improvements!

Thank you @holdenmai !

@metoule metoule merged commit 115ffa4 into dynamicexpresso:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants