Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous code in top-level directory #6

Closed
briandesilva opened this issue Dec 17, 2019 · 7 comments
Closed

Extraneous code in top-level directory #6

briandesilva opened this issue Dec 17, 2019 · 7 comments
Assignees

Comments

@briandesilva
Copy link
Member

There are a few files sitting around in the top level directory from when I first forked the project and I'm not sure whether we still need them. Specifically, the files I'm unsure about are

  • .gitmodules
  • .codecov.yml
  • .gitattributes
  • .readthedocs.yml
  • .travis.yml
@Ohjeah
Copy link
Collaborator

Ohjeah commented Dec 17, 2019

We can definitely get rid of the .gitmodules, .travis.yml and .codecov.yml.
I don't know about versioning the project yet. The original repo used versioneer to automatically infer the python package version from git tags (the .gitattributes is used for this).
Also, do we want rendered documentation on readthedocs.org?

@briandesilva
Copy link
Member Author

Great. I'll remove .gitmodules, .travis.yml, and .codecov.yml. We can hold off on modifying .gitattributes until we decide how to handle versioning.

Now that I look at it we may be able to prune some lines from requirements.txt and requirements-dev.txt.

  • requirements.txt: Can we drop the dependence on matplotlib if the only place we use it is in our example jupyter notebooks?
  • requirements-dev.txt: There are a number of requirements I suspect we can drop. Could you take a look and see if that's the case and, if so, which lines can be safely removed?

I think we will want to host documentation on readthedocs.org. You have some experience with sphinx, right? Do you have an estimate for how much effort would be required to port our documentation over to readthedocs.org?

@Ohjeah
Copy link
Collaborator

Ohjeah commented Dec 20, 2019

I think it's a matter of a few hours to get it running, but will take a lot of effort to have a nice presentable version.
It's a great way presenting the examples though and we should definitely habe the online documentation on the roadmap.

@briandesilva
Copy link
Member Author

Okay, we'll add it to our to-do list.

@Ohjeah
Copy link
Collaborator

Ohjeah commented Jan 14, 2020

@briandesilva I noticed you added support for travis again. Unit tests are now checked twice using Github actions and travis. I think staying with Github actions is fine.

@briandesilva
Copy link
Member Author

I added Travis support again so that we could include a badge indicating to users whether our latest changes pass the unit tests. I will look into accomplishing a similar outcome with GitHub actions.

@Ohjeah
Copy link
Collaborator

Ohjeah commented Jan 15, 2020

I spilt up the remaining tasks in separate issues: #14 #15 #16

@Ohjeah Ohjeah closed this as completed Jan 15, 2020
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this issue May 9, 2024
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this issue May 9, 2024
Addresses dynamicslab#6: Faster merging of date and time_step during evaluation
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this issue May 9, 2024
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants