Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix rst backticks to make CI green #254

Merged
merged 1 commit into from
Oct 4, 2022
Merged

DOC: Fix rst backticks to make CI green #254

merged 1 commit into from
Oct 4, 2022

Conversation

Jacob-Stevens-Haas
Copy link
Member

Solves the CI error:

sphinx.errors.SphinxWarning: /home/runner/work/pysindy/pysindy/pysindy/optimizers/miosr.py:docstring of pysindy.optimizers.miosr.MIOSR:12:'any' reference target not found: model

Also bump flake8 pre-commit version
@Jacob-Stevens-Haas
Copy link
Member Author

tl;dr: it was a concurrent merge issue with the MIOSR work that used rst backticks incorrectly in a docstring. Along the way, one of the dependencies for the flake8 version used in pre-commit upgraded to be incompatible with that version of flake8, so I bumped the flake8 pre-commit version.

@codecov-commenter
Copy link

Codecov Report

Base: 92.92% // Head: 92.94% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (47289dc) compared to base (02c3d05).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   92.92%   92.94%   +0.01%     
==========================================
  Files          35       34       -1     
  Lines        3507     3458      -49     
==========================================
- Hits         3259     3214      -45     
+ Misses        248      244       -4     
Impacted Files Coverage Δ
...indy/differentiation/smoothed_finite_difference.py 100.00% <ø> (ø)
pysindy/feature_library/weak_pde_library.py 95.11% <ø> (ø)
pysindy/optimizers/miosr.py 76.40% <ø> (ø)
pysindy/pysindy.py 95.03% <ø> (ø)
pysindy/utils/axes.py 95.45% <ø> (ø)
pysindy/utils/base.py 83.73% <ø> (ø)
pysindy/optimizers/base.py 92.24% <100.00%> (-0.06%) ⬇️
pysindy/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akaptano akaptano merged commit 08f9fe7 into master Oct 4, 2022
@akaptano akaptano deleted the doc-fix branch October 4, 2022 23:58
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request Apr 30, 2024
DOC: Fix rst backticks to make CI green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants