Implement support for key revision.tag=last #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est and let the tool attempt to parse out all the tags from the git repo and determine what tag should be used and if we need to update. There are additional options to set to this revision.tag=latest feature, see docs for details about each individual option.
holmboe
reviewed
Jan 24, 2022
Co-authored-by: Henrik Holmboe <henrik@dynamist.se>
…e. Add __all__ to exceptions.py and constants.py to make them properly importable with *
…sing, filter, order & select. - Replace package semver with packaging for better PEP440 support - Separate out filter, order & select to new methods to declutter update() method - Impelment unittests for new logics to validate each step and the entire chain works together as expected - New enums.py file that will be used to define all supported algorithms we have
Grokzen
changed the title
holmboe
approved these changes
Jan 31, 2022
|
|
||
| class SelectionMethods(Enum): | ||
| SEMVER = 10 | ||
| EXACT = 20 |
There was a problem hiding this comment.
Maybe use LITERAL instead of EXACT? You decide.
There was a problem hiding this comment.
I might, but let me think about it and i will push it in a future commit if i change it. I find both options a little bit wonky tbh
There was a problem hiding this comment.
I added in this as a idea card in the 1.0.0 project for keeping track of this suggestion
holmboe
reviewed
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Implement support for specifying "revision.tag=latest" key and support for a few helper options that can be used to filter and clean tags to allow for semver to work it's magic. Please see docs for additional examples and usage of all options.