Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required .tomb file extension #180

Closed
yzaguirre opened this issue Dec 22, 2014 · 1 comment
Closed

Required .tomb file extension #180

yzaguirre opened this issue Dec 22, 2014 · 1 comment
Labels
feat
Milestone
2.1

Comments

@yzaguirre
Copy link

Tomb v2 requires that the tomb file must have it's file extension set to .tomb, otherwise refuses to open it. I don't want to leave a clue of which tool I use to open said file.
tomb
@jaromil jaromil added the feat label Dec 22, 2014
@jaromil jaromil added this to the 2.1 milestone Dec 22, 2014
@JoelMon
Copy link
Contributor

JoelMon commented Dec 23, 2014

Good call.

@jaromil jaromil closed this as completed in 2598c11 Feb 8, 2015
@Narrat Narrat mentioned this issue Jun 24, 2015
Closed
@jaromil jaromil mentioned this issue Jun 26, 2015
Closed
jaromil added a commit that referenced this issue Jun 26, 2015
@jaromil
Delete mountpoint when tomb is closed (fix #149)
eada053 
two bugs were left behind by the last refactoring, one about
consistency of the mountpoint naming (now using $TOMBNAME everywhere,
without the added .tomb extension as per #180), the other about a
missing _sudo to prefix rmdir commands.

Test suite has been updated accordingly.

This fix introduces a mandatory condition for the next update: all
tombs must be closed when upgrading the tomb script, else it will not
be able to correctly close them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@jaromil @yzaguirre @JoelMon