recognize zram as swap #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if unencrypted swap is zram. If it is zram check whether a writeback to disk is configured. Unencrypted zramswap not written to disk is accepted. ToDo (as for other unencrypted swap): check if the writeback happens on an already encrypted disk/partition.
Something went wrong when I tried to move my changes from my installation into the git. Now the tests complete successfully.
|
recognizes zramswap as swap that lives in ram only if it doesn't write back to disk |
jaromil
reviewed
Oct 19, 2022
As explained to me here dyne#447 (comment) it would be bad to change existing messages. Reverted to the already existing messages and added new messages about zramswap.
|
thanks for your contribution and be welcome among tomb developers! 🎉 |
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if unencrypted swap is zram. If it is zram check whether a writeback to disk is configured.
Unencrypted zramswap not written to disk is accepted.
ToDo (as for other unencrypted swap): check if the writeback happens on an already encrypted disk/partition.