Revert "create-diff-object: support for __jump_table" #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5852ddb. The __jump_table section is more complex than the initial analysis determined. The __jump_table has three relocs per entry that must be pulled in together and one of the relocs is to symbols contained in the __tracepoints section whose rela section references the __tracepoint_strings section. So it's more complex and should just fail rather than appear that it is being handled properly. Signed-off-by: Seth Jennings <sjenning@redhat.com>
jpoimboe
added a commit
that referenced
this pull request
Apr 30, 2014
Revert "create-diff-object: support for __jump_table"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5852ddb.
The __jump_table section is more complex than the initial analysis
determined. The __jump_table has three relocs per entry that must
be pulled in together and one of the relocs is to symbols contained
in the __tracepoints section whose rela section references the
__tracepoint_strings section. So it's more complex and should just
fail rather than appear that it is being handled properly.
Issue continues to be tracked in #157
Signed-off-by: Seth Jennings sjenning@redhat.com