Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crux-ui): overwritten deployment secrets #939

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Mar 24, 2024

Fixes an issue where adding a secret to the instance config overwrites the exiting ones.

@m8vago m8vago requested a review from a team as a code owner March 24, 2024 12:55
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript pr:fix labels Mar 24, 2024
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested.

@m8vago m8vago merged commit 8b467a2 into develop Mar 24, 2024
26 checks passed
@m8vago m8vago deleted the fix/deployment-secrets branch March 24, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:typescript pr:fix source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants