Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockchain] disable service links #290

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[blockchain] disable service links #290

merged 1 commit into from
Feb 26, 2024

Conversation

VladStarr
Copy link
Contributor

@VladStarr VladStarr commented Feb 26, 2024

By disabling we fix annoying warnings in Geth log
Unknown config environment variable envvar=GETH_

Leaving that option configurable, but disabled by default.

@VladStarr VladStarr requested a review from voron February 26, 2024 11:47
Copy link
Contributor

@voron voron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a side note, there are no issues on BSC side due to extra env vars.

@VladStarr
Copy link
Contributor Author

LGTM

Just a side note, there are no issues on BSC side due to extra env vars.

I've added it for future, once upon a time upstream Geth will be merged into BSC :)

@VladStarr VladStarr merged commit 3c596df into main Feb 26, 2024
2 checks passed
@VladStarr VladStarr deleted the disable-service-links branch September 20, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants