Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add VidClub source and Prefect tasks #1044

Merged
merged 21 commits into from
Oct 4, 2024
Merged

✨ Add VidClub source and Prefect tasks #1044

merged 21 commits into from
Oct 4, 2024

Conversation

adrian-wojcik
Copy link
Contributor

Summary

Adding VidClub connector

Importance

To use VidClub in Prefect 2.0

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@adrian-wojcik adrian-wojcik changed the base branch from main to 2.0 September 20, 2024 08:24
trymzet
trymzet requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed

src/viadot/orchestration/prefect/flows/vid_club_to_adls.py Outdated Show resolved Hide resolved
tests/unit/test_vid_club.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/vid_club_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
@trymzet trymzet changed the title Vid club 2.0 ✨ Add VidClub source and Prefect tasks Sep 27, 2024
trymzet
trymzet requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same stuff basically

@Rafalz13 Rafalz13 requested a review from trymzet October 1, 2024 07:53
trymzet
trymzet requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more comment, also:

  • pls address previous feedback as it's not implemented yet
  • I would remove the integration tests as you're mocking the response so they're not really integration tests, or remove the Prefect part and just add the tests as unit

src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 requested a review from trymzet October 2, 2024 11:45
trymzet
trymzet requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing left, already pointed out in #1044 (comment)

src/viadot/sources/vid_club.py Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 requested a review from trymzet October 2, 2024 14:13
@trymzet trymzet merged commit 8492477 into 2.0 Oct 4, 2024
3 checks passed
@trymzet trymzet deleted the vid_club_2.0 branch October 4, 2024 08:28
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 left review comments

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
2.0 viadot 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrian-wojcik @trymzet @Rafalz13 @fdelgadodyvenia