-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add SAPBW
source and Prefect tasks
#1053
Conversation
@gwieloch it seems the checks are failing, can you make sure they pass first, then request PR review? Otherwise I would need to check the same code twice. Also, pls rebase as well. As for the tests failing due to For more info, see the "optional dependencies" sections in the developer guide docs https://viadot.docs.dyvenia.com/developer_guide/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks not passing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments. Some unit tests should also be added.
Sapbw
source and Prefect tasksSAPBW
source and Prefect tasks
Summary
SAP BW connector migration from viadot 1 to viadot 2. Also added some utility functions into viadot utils.
Importance
Required by the migration project.
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md