Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix do-wrapper API issues #28

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix do-wrapper API issues #28

merged 1 commit into from
Feb 18, 2021

Conversation

jd20
Copy link
Contributor

@jd20 jd20 commented Aug 1, 2018

Found two issues, preventing easy-proxy from running properly:

  1. Location of do-wrapper's constructor has changed, must now be imported as require('do-wrapper').default.
  2. To return all distributions, getImagesAll must be called with type=distribution now.

This fixes both the "DigitalOcean is not a constructor" error, and the "CentOS 7 not found" error. (Maybe also fixes the hanging on fetching images, which might be caused by the constructor issue.)

@lukefigs
Copy link

lukefigs commented Aug 2, 2018

i tested this personally and it appears to fix any errors that i was having with fetching images! thanks

@drhema
Copy link

drhema commented Aug 14, 2018

@jd20 where we should use
require('do-wrapper').default.
type=distribution

please illustrate or tell us the idea...of where to put these codes?

Thanks in advanced and wait your reply

@jd20
Copy link
Contributor Author

jd20 commented Aug 15, 2018

It's shown in the PR, did you look at the code changes?

@drhema
Copy link

drhema commented Aug 15, 2018

@jd20 so sorry, i'm just googling how to create proxy in digitalocean and came across here, i'm not coder and dont know where is PR and what happen here
i just curus of using this amazing software but still have the issue that reported here and u solved but dont understand where to write these codes or if there is a ready solution for zero code knowledge like me

Thanks in advance.

@jd20
Copy link
Contributor Author

jd20 commented Aug 15, 2018

Just grab the code from my fork, it has the fixes already applied:
https://github.com/jd20/easy-proxy

@drhema
Copy link

drhema commented Aug 16, 2018

@jd20 sorry for bothering you, but i see just source code file not .exe file
sorry for wasting your time, but seems on github no place for newbies or non coders!

@jd20
Copy link
Contributor Author

jd20 commented Aug 16, 2018

@drhema Yeah, a new exe won't be created, until the maintainer (@dzt) merges my PR, and creates a new release. If you have git / npm installed, you can follow the instructions he gives to run it locally, under the section "Setup (for development)" in the README. Just modify the git clone command to be: git clone https://github.com/jd20/easy-proxy.git. That will pull my version of the code, which has the fixes.

Yeah, github is designed for developers to collaborate on open source projects... anyway, there's not much that can be done to fix your issue, other than wait for the maintainer to merge the fix.

@itemsCenter
Copy link

Anyone knows how do I fix this guys?
https://i.imgur.com/O2AkFjc.png

It's still stuck on Fetching Images...

@apathy
Copy link

apathy commented Apr 3, 2019

@jd20 Any updates or fixes for this?

@jd20
Copy link
Contributor Author

jd20 commented Apr 3, 2019

@apathy The fix has been waiting since last year for @dzt to merge it, if you want it merged you should let him know.

@apathy
Copy link

apathy commented Apr 3, 2019

Doesn't seem to work for me. This is with your fixes too. @jd20
image

@jd20
Copy link
Contributor Author

jd20 commented Apr 3, 2019

Right, that's the error I fixed. You need to either check out and run easy-proxy from my branch (fix_do_api), or ask @dzt to merge my PR so everybody will get the fix. That's how fixes on GitHub projects work, I don't have access to merge the fix myself.

See my comment above, I explained basically the same thing.

@apathy
Copy link

apathy commented Apr 3, 2019

@jd20 Got it. I've went ahead and used your fix properly now. Is this normal? I've put my API key but that drop down is blocked out.
image

@rh2830
Copy link

rh2830 commented Apr 16, 2019

Right, that's the error I fixed. You need to either check out and run easy-proxy from my branch (fix_do_api), or ask @dzt to merge my PR so everybody will get the fix. That's how fixes on GitHub projects work, I don't have access to merge the fix myself.

See my comment above, I explained basically the same thing.

Works perfectly using your fix. thank you so much for making it public, greatly appreciated

@richdevid
Copy link

Thank you, you saved my life

@mikelucid
Copy link

Found two issues, preventing easy-proxy from running properly:

  1. Location of do-wrapper's constructor has changed, must now be imported as require('do-wrapper').default.
  2. To return all distributions, getImagesAll must be called with type=distribution now.

This fixes both the "DigitalOcean is not a constructor" error, and the "CentOS 7 not found" error. (Maybe also fixes the hanging on fetching images, which might be caused by the constructor issue.)

thanks for the fork!!

@dzt dzt merged commit 8323c70 into dzt:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants