Slotify list section #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci (semantic-release): Allow release on other branches as well.
Merge remote-tracking branch 'origin/next' into slotify-list-section
Dramaturco
force-pushed
the
slotify-list-section
branch
from
2aceebe
to
12a1606
Compare
Replaced renderItem prop with mandatory item scoped slot. Added optional filter scoped slot to allow for custom rendering of the filter buttons.
Dramaturco
force-pushed
the
slotify-list-section
branch
from
58c1187
to
f6a4418
Compare
vlapl
reviewed
Jan 19, 2021
src/types/sections.d.ts
Outdated
| export interface ListSectionProps<Item> { | ||
| /** | ||
| * You can pass an optional headline that will be displayed in top of your items. | ||
| * You can pass an optional headline that will be displayed on top of your items. |
There was a problem hiding this comment.
instead of "on top" I'd prever "above" or "before"
|
looks good to me (I just left one comment on preposition use in a code comment, which could be improved) |
added 2 commits
January 19, 2021 12:30
Merge branch 'next' into slotify-list-section
fix: comment Reworded a type description for headline
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Slots to the ListSection. The renderItem prop was replaced by a scopedSlot called item. The filter buttons can now also be rendered using a scoped slot. This is optional though.