Slotify googlemaps section #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci (semantic-release): Allow release on other branches as well.
Merge remote-tracking branch 'origin/next' into slotify-googlemaps-section
|
This pr is looking good to me. But I'm having an issue with the tests: trying to run the GoogleMapsSection unit test I'm getting a fatal error. It seems like a previous test overrode requiredProps.language with "e"... but not doing that any longer just leads to a different error on my system... giving up for today. |
|
Yes I see it. I'll fix this right away. |
vlapl
approved these changes
Jan 19, 2021
feat: Slotify Googlemaps section Googlemaps section now has 2 scoped slots. Title: allows users to render a custom title. LocationItem: allows users to render custom location items in the list on the right (or below). Changed the styling a little bit.
Dramaturco
force-pushed
the
slotify-googlemaps-section
branch
from
d5fbb16
to
5078948
Compare
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title and the items in the list rendering are now scoped slots. The custom rendering for the info window pop-ups works differently and cannot easily be turned into slots. Because it uses the googlemaps API to render and that expects a DOM-Node