-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows - rename event is split into two events #44
Comments
I have a potential fix for this, I will post a PR tomorrow... |
I have not given Windows the care it deserves. Any help getting Windows up to par is greatly appreciated. |
Also, if it's easier for you/depending on what you prefer, you can choose to make changes directly in the amalgamated include/wtr/watcher.hpp file. Currently, we're set up to amalgamate relevant files in devel/ into include/wtr/watcher.hpp. However, it's an extra step, and the library is small enough that working directly on a single file might be more convenient/natural. So, up to you, but we can just remove the whole amalgamation step and whatnot if it suits you. |
@e-dant - did you mean to close the other issue? The PR for this is still open FWIW |
I'm on Windows 11 and it seems like rename events are sending two events, unlike the example in the README where there is one event with both the old and the new name. First the old name is sent, then the new name and
associated
is alwaysnullptr
.The text was updated successfully, but these errors were encountered: