Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - rename event is split into two events #44

Closed
iwubcode opened this issue Jul 4, 2024 · 4 comments
Closed

Windows - rename event is split into two events #44

iwubcode opened this issue Jul 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@iwubcode
Copy link
Contributor

iwubcode commented Jul 4, 2024

I'm on Windows 11 and it seems like rename events are sending two events, unlike the example in the README where there is one event with both the old and the new name. First the old name is sent, then the new name and associated is always nullptr.

@iwubcode
Copy link
Contributor Author

iwubcode commented Jul 4, 2024

I have a potential fix for this, I will post a PR tomorrow...

@e-dant e-dant added the bug Something isn't working label Jul 4, 2024
@e-dant
Copy link
Owner

e-dant commented Jul 4, 2024

I have not given Windows the care it deserves.

Any help getting Windows up to par is greatly appreciated.

@e-dant
Copy link
Owner

e-dant commented Jul 4, 2024

Also, if it's easier for you/depending on what you prefer, you can choose to make changes directly in the amalgamated include/wtr/watcher.hpp file.

Currently, we're set up to amalgamate relevant files in devel/ into include/wtr/watcher.hpp.

However, it's an extra step, and the library is small enough that working directly on a single file might be more convenient/natural.

So, up to you, but we can just remove the whole amalgamation step and whatnot if it suits you.

@iwubcode
Copy link
Contributor Author

iwubcode commented Jul 5, 2024

@e-dant - did you mean to close the other issue? The PR for this is still open FWIW

@e-dant e-dant reopened this Jul 8, 2024
@e-dant e-dant closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants