-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mpl.cbook.matplotlib depreciation warning #39
base: master
Are you sure you want to change the base?
Fix mpl.cbook.matplotlib depreciation warning #39
Conversation
This symbol has moved from mpl.cbook.MatplotlibDepreciationWarning to mpl.MatplotlibDepreciationWarning
Thank you for your fix. |
Can confirm as described in the matplotlib API changes for 3.8.0: cbook removals. |
Checked and working great with the latest version of matplotlib! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix is necessary otherwise no newer matplotlib version supported
We also need to specify the versions of dependencies to ensure this lib to work. |
One last aprove needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If anybody wants to make use of the fix until its pushed then you can always do the following: |
Fix the
mpl.cbook.MatplotlibDeprecationWarning
symbol tompl.MatplotlibDeprecationWarning
. Without this, july won't show any charts for newer versions of matplotlib.Also bump version number.