Correctly order the dashboard and diary tabs when they are present. #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After conditional inclusion. As part of the fix(es) for e-mission/e-mission-docs#875 (comment) 11954, we turned off the diary screen and the dashboard screen if they didn't make sense for the current configuration. This was not super well tested, so we needed a couple of backup fixes (334c024, e8c6c5c), but it finally got done in 8a05333 However, in the (common) case where all the screens were labeled, because the conditionals for the screens were evaluated only after the dynamic config was done, they were tacked on at the end, so the order looked weird. This was surprisingly hard to fix, some options that didn't work were: - putting an ng-if scope variable across the entire main.html to delay the initialization of the tabs - using `hidden` and `disable` tags So finally, I decided to use jquery to access the HTML elements directly and move them around. Note that these HTML elements are not the `ion-tab` elemeents, although they do have a 1:1 mapping. It turns out that at the end of the `DynamicConfig` callback, only two tabs have been added. However, in the `afterEnter` callback, we can see all 4 tabs!! So we move the diary and dashboard (if they exist) to before and after the label screen. Testing done: - MULTILABEL (`stage-study`): all tabs appear in the correct order - ENEKETO (`study-program`): only label and profile tabs appear
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes e-mission/e-mission-docs#875
Fix visible at: e-mission/e-mission-docs#875 (comment)