-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED implementation for optimization #534
Conversation
Two things that I realized directly:
|
matRad_calcDoseFillDij.m
Outdated
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD')) ... | ||
&& strcmp(pln.radiationMode,'carbon') | ||
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD') ... | ||
||isequal(pln.propOpt.bioOptimization,'BED') ) && strcmp(pln.radiationMode,'carbon') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be LEMIV_BED? for consistency
matRad_calcDoseFillDij.m
Outdated
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD')) ... | ||
&& strcmp(pln.radiationMode,'carbon') | ||
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD') ... | ||
||isequal(pln.propOpt.bioOptimization,'BED') )&& strcmp(pln.radiationMode,'carbon') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the previous comment
This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR. |
…to dev_BEDprojection_Jen
Dev BED projection
The merge was done incorrectly. Problem is that during the merge you did not take care of correctly translating the changed code of the dose calculation contents into the engines (fillDij etc.). So now you have readded those files in your merge, which messes up the history and will cause problems in future merges. This means we can not really integrate this PR anymore without causing trouble. Thus I suggest to:
|
refer to PR #744 : redo of this PR into new matrad file structure |
BED Projection reimplementation based on PR #534
Incorperated BED projection in MatRad, so that optimazion can now be performed with BED