Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED implementation for optimization #534

Closed
wants to merge 18 commits into from

Conversation

JenHardt
Copy link

@JenHardt JenHardt commented Dec 3, 2021

Incorperated BED projection in MatRad, so that optimazion can now be performed with BED

@wahln
Copy link
Contributor

wahln commented Mar 17, 2022

Two things that I realized directly:

  • Starting up the matRadGUI and then loading a patient directly causes an error.
  • Are the number of fractions in each optimization objective really necessary for the BED computation? It should be enough that the number of fractions is stored in the BED-Projection, right, because I don't see those values being used when called from the matRad_OptimizationProblem functions

@wahln wahln changed the title Dev BED projection BED implementation for optimization Aug 2, 2022
@wahln wahln self-assigned this Nov 23, 2022
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD')) ...
&& strcmp(pln.radiationMode,'carbon')
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD') ...
||isequal(pln.propOpt.bioOptimization,'BED') ) && strcmp(pln.radiationMode,'carbon')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be LEMIV_BED? for consistency

if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD')) ...
&& strcmp(pln.radiationMode,'carbon')
if (isequal(pln.propOpt.bioOptimization,'LEMIV_effect') || isequal(pln.propOpt.bioOptimization,'LEMIV_RBExD') ...
||isequal(pln.propOpt.bioOptimization,'BED') )&& strcmp(pln.radiationMode,'carbon')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the previous comment

matRad_calcCubes.m Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 7, 2024

This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR.

@github-actions github-actions bot added the stale Automatic label for stale issues label Jul 7, 2024
@wahln
Copy link
Contributor

wahln commented Jul 9, 2024

The merge was done incorrectly.

Problem is that during the merge you did not take care of correctly translating the changed code of the dose calculation contents into the engines (fillDij etc.). So now you have readded those files in your merge, which messes up the history and will cause problems in future merges.

This means we can not really integrate this PR anymore without causing trouble.

Thus I suggest to:

  1. Create a new clean branch from dev
  2. Copy the changed files to this branch to recreate the simpler changes
  3. Make sure the changes to the engine reflect what was originally changed in the PR in the old procedural dose calculation structure.
  4. Create a clean new PR on the dev branch

@amitantony
Copy link
Contributor

refer to PR #744 : redo of this PR into new matrad file structure

@amitantony amitantony closed this Jul 9, 2024
wahln added a commit that referenced this pull request Jul 19, 2024
BED Projection reimplementation based on PR #534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Automatic label for stale issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants