Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu manager and admin folder with _menu file. #4056

Closed
Jimmi08 opened this issue Dec 30, 2019 · 3 comments
Closed

Menu manager and admin folder with _menu file. #4056

Jimmi08 opened this issue Dec 30, 2019 · 3 comments
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 30, 2019

Question to menus and menu manager

This is the question because I don't know if this is the intention or not. Maybe for some functionality in admin area? No idea.

I thought that you can create menu files only in the main plugin directory with the name _menu.php.

But if you create folder "admin" and put there admin_menu.php file, then menus records are created. It doesn't work for another subfolder name, only for admin. Otherwise, this would be nice feature with subfolder menus.

It loads admin_menu from main folder too (legacy plugins):
image

Problem is that you don't know about those records via Menu Manager (only latest one is displayed)

image

Expected Source

I tried to check the documentation about rules for creating PHP menus files.

Additional Context

If this is the intention, no problem, I will rename my files. I just want to know the rules.

@Jimmi08 Jimmi08 added the type: question An ask about behavior that is not found documented anywhere label Dec 30, 2019
@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Apr 28, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Apr 28, 2020

It's a bug. It should not be detected _menu.php files inside 'admin'.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Apr 29, 2020

It's a bug. It should not be detected _menu.php files inside 'admin'.

But nothing important, nobody else uses this and I changed the name for that file.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 30, 2021

Still bug.
@Moc Could you remove label question? Thanks
image

@Moc Moc removed the type: question An ask about behavior that is not found documented anywhere label Aug 30, 2021
@Moc Moc added this to the e107 2.3.2 milestone Dec 21, 2021
@CaMer0n CaMer0n modified the milestones: e107 2.3.2, e107 2.3.3 Apr 7, 2022
@CaMer0n CaMer0n changed the title menu manager and admin folder with _menu file. Menu manager and admin folder with _menu file. Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants