Glyphs on version 2.3.2 do not work

[sensei116]

Bug Description

Glyph table is half-empty.
It looks that the issue is in "private function glyphTab($cat='', $parm=array())".
This function works fine for 2.3.0.

How to Reproduce

Steps to reproduce the behavior:

1. Go to "Navigation" settings and try to create new menu link.
2. Click on icon, select "glyphs" tab.
3. See error

Expected Behavior

It will be good, if this works like it was in 2.3.0 - the full tab of glyph icons.

Screenshots

Server Information

PHP Operating System

Linux DCS-KAZLAB-ROOT 4.19.0-5-amd64 #1 SMP Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64

PHP Version

PHP Version 7.3.31-1~deb10u1

PHP Modules

apache2handler
calendar
Core
ctype
curl
date
dom
exif
fileinfo
filter
ftp
gd
gettext
hash
iconv
json
libxml
mbstring
mysqli
mysqlnd
openssl
pcre
PDO
pdo_mysql
Phar
posix
readline
Reflection
session
shmop
SimpleXML
sockets
sodium
SPL
standard
sysvmsg
sysvsem
sysvshm
tokenizer
wddx
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zlib

Client Information

Your user agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
Other HTTP headers
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,/;q=0.8
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.5
Host: duckduckgo.com
TE: trailers
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0
SEC-FETCH-DEST: document
SEC-FETCH-MODE: navigate
SEC-FETCH-SITE: none
SEC-FETCH-USER: ?1
SSL-JA3-HASH: be12eb3bab3313e8d159fd00f469cae2
UPGRADE-INSECURE-REQUESTS: 1

[Jimmi08]

Confirmed.
the reason is wrong markup for old glyphicons
<i class="glyphicon glyphicon-glyphicon-collapse-down"></i>
it should be
<i class="glyphicon glyphicon-gcollapse-down"></i>

For me bigger issue is mixed FA 5 a Glyphs icons under label bootstrap...

[sensei116]

I am not sure if I have done the right thing, but if I remove this part (please see screenshot attached), then it looks finally better.
But it is strange, that in 2.3.2 we have less glyphs amount than it was in 2.3.0.

[Jimmi08]

Your fix looks as solution for admin.

Your frontend theme should add icons set too... because what is good to have there glyphicons set if your frontend theme doesn't support them and they will not be displayed? If there is the same icon name for FA 4 and FA 5 - f.e. envelope - you will not notice difference.

I am sorry, I had lost track about how glyphs work in e107 already...

[CaMer0n]

@sensei116 Thank you for posting this issue. What theme are you using? If it's not from the e107 release, could you please post the contents here of your theme.xml

[sensei116]

Hi Cameron!   I use VOUX theme skin with minor changes in «theme.xml» file. You can find it out attached to the email.   It looks that I have finally solved the issue. * I have done all the things I have listed in bug report * Then I copied «fonts» folder from theme bootstrap3 to my theme folder. * Then I cleared system cache (just physically deleted it from the host. For now, many-many glyphs appeared in admin area functions (bootstap3 skin), and all of them are correctly recognized by the site pages available for users (VOUX skin).  [theme.zip](https://github.com/e107inc/e107/files/9030164/theme.zip)

[CaMer0n]

Thank you @sensei116, much appreciated!

When I install VOUX, I only get the FontAwesome 4 glyphs in the admin area (which is the intended behavior). I see from your theme.xml file that you should be seeing FontAwesome 5 glyphs, so I'm not sure why Bootstrap glyphs are appearing for you. Is it possible you have something like this in your theme.php file? :

define("FONTAWESOME", X);

If so, you can remove it.

[sensei116]

Hi Cameron.

Yep. I have so:

When I remove it I see glyphs v.5 anyway:

But it can be related to changes that I have made previously to fix the issue. So, I am not 100% sure if it is the final solution or not.
But for now anything works fine, so e107 is the best again! :)