Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Table Captions with HTML please #5272

Open
Vodhin opened this issue Jun 5, 2024 · 2 comments
Open

[Feature request]: Table Captions with HTML please #5272

Vodhin opened this issue Jun 5, 2024 · 2 comments
Labels
type: enhancement An improvement or new feature request

Comments

@Vodhin
Copy link

Vodhin commented Jun 5, 2024

Motivation

I would like to use html tags in the Caption of table render so I can add icons or other interface elements to front end pages. It seems that tablerender strips them out via e107::getParser()->toText($caption) - and this is odd - for some themes and not others. When I change it to e107::getParser()->toHTML($caption) then all works ok.

Proposed Solution

In e_render_class.php:
Change
401: $options['caption'] = e107::getParser()->toText($caption);
to:
401: $options['caption'] = e107::getParser()->toHTML($caption);

Alternatives

No Alternative exists.

Additional Context

No response

@Vodhin Vodhin added the type: enhancement An improvement or new feature request label Jun 5, 2024
@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 6, 2024

I think you are doing something wrong. This was never an issue before. Weird.

@Vodhin
Copy link
Author

Vodhin commented Jun 8, 2024

I think you are doing something wrong. This was never an issue before. Weird.

I noticed it when testing different Themes. The current ->toText() works with Bootstrap 3 and Voux but does not work with Bootstrap 5 themes. Changing this to ->toHTML() makes it work with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

2 participants