Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for versions specified in metadata.rb, if a lock isn't found #3

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

e1ven
Copy link
Owner

@e1ven e1ven commented Mar 4, 2021

Fix for java import-

After importing the old pre-lock json, pre-internal gives-

Synchronizing Cookbooks:
...
  - java (8.5.0)
...

After updating to this version, it gives

Synchronizing Cookbooks:
...
  - java (4.3.0)
...

Testing

[x] Update lock on a top-level cookbook, verify it pulls a newer release.
[x] Update lock to top-level cookbook, verify it pulls older release.
[x] Update env lock on dependent cookbook, verify it pulls newer release.
[x] Update env lock on dependent cookbook, verify it pulls older release.
[x] Update metadata.rb lock on dependent cookbook, verify it pulls newer release. (This PR)
[x] Update metadata.rb lock on dependent cookbook, verify it pulls older release. (This PR)
[x] Update env lock to non-existent version, verify it fails.
[x] Restore env lock to existent version, verify it recovers.

@e1ven e1ven changed the title dox-java vix Fix for versions specified in metadata.rb, if a lock isn't found Mar 4, 2021
Copy link
Collaborator

@Shadowssong Shadowssong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good with regression test

@e1ven e1ven requested a review from genevieve March 4, 2021 17:05
@e1ven e1ven merged commit 689c6ea into v0.11.11 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants