Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor errors in stanet converter #461

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jkisse
Copy link
Collaborator

@jkisse jkisse commented Jan 5, 2023

  • stanet_nr is now -999 instead of NA (if applicable)
  • remove xfails and unused imports
  • fail-safe if no layers available
  • fail-safe if slider diameter = 0

todo:

  • add note in documentation (simulation in stanet required prior to export, HA pipes)

closes #390

- stanet_nr is now -999 instead of NA (if applicable)
- remove xfails and unused imports
- fail safe if no layers available
- fail safe if slider diameter = 0
@jkisse jkisse requested a review from dlohmeier January 5, 2023 09:59
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 84.96% // Head: 85.14% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (03adb94) compared to base (7c665e8).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #461      +/-   ##
===========================================
+ Coverage    84.96%   85.14%   +0.18%     
===========================================
  Files           90       90              
  Lines         6072     6073       +1     
===========================================
+ Hits          5159     5171      +12     
+ Misses         913      902      -11     
Impacted Files Coverage Δ
pandapipes/converter/stanet/stanet2pandapipes.py 77.92% <75.00%> (+0.70%) ⬆️
pandapipes/converter/stanet/table_creation.py 66.22% <100.00%> (+1.72%) ⬆️
pandapipes/converter/stanet/preparing_steps.py 81.30% <0.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dlohmeier dlohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding the tests and the quick fixes.

@dlohmeier dlohmeier merged commit acd3a53 into e2nIEE:develop Jan 5, 2023
@jkisse jkisse deleted the fix/stanet_converter branch January 5, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STANET Converter
2 participants