Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create function for multiple heat exchangers #503

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

SimonRubenDrauz
Copy link
Collaborator

create multi heat exchanger at once

sdrauz and others added 2 commits January 31, 2023 09:53
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 85.14% // Head: 85.06% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (437842d) compared to base (fd76539).
Patch coverage: 14.28% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #503      +/-   ##
===========================================
- Coverage    85.14%   85.06%   -0.09%     
===========================================
  Files           90       90              
  Lines         6073     6080       +7     
===========================================
+ Hits          5171     5172       +1     
- Misses         902      908       +6     
Impacted Files Coverage Δ
pandapipes/create.py 90.43% <14.28%> (-1.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkisse
Copy link
Collaborator

jkisse commented Jan 31, 2023

please update heat_exchanger_component.rst, too

For creating multiple sources at once:

.. autofunction:: pandapipes.create_heat_exchangers

(somehow, I cannot write on the source branch)

@SimonRubenDrauz
Copy link
Collaborator Author

Agree. Adapted it accordingly.

@jkisse jkisse changed the title multiple heat exchanger at once add create function for multiple heat exchangers Jan 31, 2023
@jkisse jkisse merged commit 01377f9 into e2nIEE:develop Jan 31, 2023
SimonRubenDrauz added a commit to senergyNets/pandapipes that referenced this pull request Jan 31, 2023
add create function for multiple heat exchangers (e2nIEE#503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants