Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 0.8.4 #510

Merged
merged 17 commits into from
Feb 2, 2023
Merged

Hotfix 0.8.4 #510

merged 17 commits into from
Feb 2, 2023

Conversation

SimonRubenDrauz
Copy link
Collaborator

No description provided.

SimonRubenDrauz and others added 6 commits January 9, 2023 10:21
Hotfix for nx_graph creation of networks with flow controllers, as the keywords concerning them were not correctly considered within the function (include_flow_controls could not be set to False).
bugfix if all pumps are out of service
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 85.06% // Head: 85.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4440f81) compared to base (01377f9).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #510   +/-   ##
========================================
  Coverage    85.06%   85.06%           
========================================
  Files           90       90           
  Lines         6080     6081    +1     
========================================
+ Hits          5172     5173    +1     
  Misses         908      908           
Impacted Files Coverage Δ
pandapipes/std_types/std_type_class.py 68.34% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
pandapipes/__init__.py 100.00% <100.00%> (ø)
pandapipes/component_models/pump_component.py 98.05% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SimonRubenDrauz SimonRubenDrauz merged commit 3e7dbfd into develop Feb 2, 2023
@SimonRubenDrauz SimonRubenDrauz deleted the hotfix_0.8.4 branch February 2, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants