Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Python 3.7 from test workflow #524

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

jkisse
Copy link
Collaborator

@jkisse jkisse commented Mar 13, 2023

Python 3.7 tests are currently failing and there is not really a need to fix them. This PR adapts the GitHub Actions script so that Python 3.7 will no longer be tested.
closes #499

@jkisse jkisse added the bug Something isn't working label Mar 13, 2023
@jkisse jkisse requested a review from dlohmeier March 13, 2023 13:58
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9527ded) 85.06% compared to head (bdd89f9) 85.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #524   +/-   ##
========================================
  Coverage    85.06%   85.06%           
========================================
  Files           90       90           
  Lines         6080     6080           
========================================
  Hits          5172     5172           
  Misses         908      908           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dlohmeier dlohmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pandapower now introduces python 3.8 specific implementations (like string formatting notation), this makes sense and should encourage to adapt such kind of notations, as they are easier to implement and read.

@jkisse jkisse merged commit cf96a09 into e2nIEE:develop Mar 15, 2023
@jkisse jkisse deleted the fix/remove3_7 branch March 15, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
2 participants