Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal component arrays #561

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

dlohmeier
Copy link
Collaborator

  • added "components" dict of arrays to pit
  • every component can create its own internal array if needed (create_component_array in base_component.py)
  • moved PRESSURE_RATIO and STD_TYPE from branch_idx.py to internal arrays of pumps and compressors, as they are only needed right there

- added "components" dict of arrays to pit
- every component can create its own internal array if needed (create_component_array in base_component.py)
- moved PRESSURE_RATIO and STD_TYPE from branch_idx.py to internal arrays of pumps and compressors, as they are only needed right there
@dlohmeier dlohmeier requested review from SimonRubenDrauz and jkisse and removed request for SimonRubenDrauz September 6, 2023 07:49
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 98.66% and project coverage change: +0.07% 🎉

Comparison is base (513ef67) 85.16% compared to head (e983e90) 85.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
+ Coverage    85.16%   85.23%   +0.07%     
===========================================
  Files           90       90              
  Lines         6166     6202      +36     
===========================================
+ Hits          5251     5286      +35     
- Misses         915      916       +1     
Files Changed Coverage Δ
pandapipes/component_models/component_toolbox.py 95.65% <85.71%> (-0.86%) ⬇️
...component_models/abstract_models/base_component.py 90.38% <100.00%> (+0.58%) ⬆️
...andapipes/component_models/compressor_component.py 100.00% <100.00%> (ø)
...dapipes/component_models/flow_control_component.py 100.00% <100.00%> (ø)
pandapipes/component_models/pump_component.py 98.29% <100.00%> (+0.17%) ⬆️
pandapipes/idx_branch.py 100.00% <100.00%> (ø)
pandapipes/pf/pipeflow_setup.py 89.49% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

- rename internal to only_active
- made component_type interchangeable ("brach" / "node")
@dlohmeier dlohmeier merged commit 9fccd73 into e2nIEE:develop Sep 11, 2023
13 checks passed
@dlohmeier dlohmeier deleted the feature/component_pit branch September 11, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants