Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readthedocs.yml deprecation #565

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

SimonRubenDrauz
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9fccd73) 85.23% compared to head (3f648a8) 85.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #565   +/-   ##
========================================
  Coverage    85.23%   85.23%           
========================================
  Files           90       90           
  Lines         6202     6202           
========================================
  Hits          5286     5286           
  Misses         916      916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkisse
Copy link
Collaborator

jkisse commented Sep 15, 2023

fyi, I tried something similar already in #558 and it did not work (RTD build was failing) so I had to revert it. Have you already tested RTD based on your feature branch, @SimonRubenDrauz ?

@SimonRubenDrauz
Copy link
Collaborator Author

@jkisse, thanks for your comment. I actually also updated the webhook for RTD. As you can see it is also checking if the RTD doc is correctly built what was successful for this PR. Is this what you mean?

@SimonRubenDrauz SimonRubenDrauz merged commit 6a87439 into e2nIEE:develop Sep 15, 2023
13 checks passed
@SimonRubenDrauz SimonRubenDrauz deleted the readthedocs.yml branch September 15, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants