Added unsupplied_junctions and elements_on_path to pandapipes #592
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #592 +/- ##
===========================================
- Coverage 90.62% 90.49% -0.14%
===========================================
Files 138 139 +1
Lines 10457 10556 +99
===========================================
+ Hits 9477 9553 +76
- Misses 980 1003 +23 ☔ View full report in Codecov by Sentry. |
|
|
||
| **element** (string, "l") - element type of type BranchComponent | ||
|
|
||
| **multi** (boolean, True) - True: Applied on a NetworkX MultiGraph |
There was a problem hiding this comment.
I guess "multi" is not needed in the docs?
| """ | ||
| table_names = get_all_branch_component_table_names() | ||
| if element not in table_names: | ||
| raise ValueError("Invalid element type %s" % element) |
There was a problem hiding this comment.
As far as I understand, this check is not required to prevent errors. Could we make it optional via another default argument?
| """ | ||
| def get_all_subclasses(cls): | ||
| all_subclasses = list() | ||
| for subclass in cls.__subclasses__(): |
There was a problem hiding this comment.
Does __subclasses__ search for appearances in the whole python path? If not, we might need to find a different implementation that checks the appearing classes inside the net...
There was a problem hiding this comment.
Yes, subclasses includes all child classes and is not dependent from net
|
@dlohmeier thx for your suggestions, i implemented the changes :) |
new function calc_distance_to_junctions
new function plot_pressure_profile
|
@dlohmeier I added the functions for plot_pressure_profile to this PR aswell |
removed some unnecessary lines of code
| return [mg.get_edge_data(b1, b2)["key"][1] for b1, b2 in zip(path, path[1:]) | ||
| if mg.get_edge_data(b1, b2)["key"][0] == element] | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
I think this is not really necessary, the file should just be seen as a module from where to load functions. Can we just delete the "main" part?
vectorized plotting
removed unused import
added x0 to junction coordinates
Added unsupplied_junctions and elements_on_path with tests to pandapipes.
Added the convenience functions get_all_branch_component_table_names and get_all_branch_component_models to prevent hardcoding the branch element table names like in pandapower.