renamed JAC_DERIV_DT1 to JAC_DERIV_DTOUT in branch_idx #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might also change JAC_DERIV_DT to JAC_DERIV_DTIN, but this is not reflected by any other variable, as the temperature used here belongs to the node (so it could be called JAC_DERIV_DTNODE as well). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #598 +/- ##
==========================================
Coverage ? 90.49%
==========================================
Files ? 139
Lines ? 10549
Branches ? 0
==========================================
Hits ? 9546
Misses ? 1003
Partials ? 0 ☔ View full report in Codecov by Sentry. |
SimonRubenDrauz
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think using TOUT here acknowledges that we are always using the pipe outlet temperature considering the flow direction, which is also been reflected by the naming of the corresponding variable TOUTINTIT.