TDAR calculation

[allopole]

confirmed tdar output of get_stats() plot is linear:

[e3bo]

Why was the tau for TDAR ever negative then? Maybe there is a bug in the tau calculation.

…

On Thu, Apr 25, 2019 at 10:49 AM Eric Marty ***@***.***> wrote: confirmed tdar output of get_stats() plot is linear: [image: image] <https://user-images.githubusercontent.com/15397616/56745036-9dd79100-6747-11e9-883b-c165dc7ee056.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABVBII3MOZBNCK3BUWWYETPSHAGLANCNFSM4HIN4JNA> .

[allopole]

Spencer fixed a bug in the TDAR calculation inside get_stats() in his fork of spaero. See:

SpencerDH@477d42c

[e3bo]

I have pushed this fix to the tdar branch of e3bo/spaero. I want to make sure we follow up on the tau issue. Can you reproduce the negative tau with a buggy tdar output like above?

[allopole]

We reproduced it. Problem was in how ktseq() function in analysis.R handled missing values. Eamon replaced with R corr function that handles missing values properly.