Badge: the position of the badge is wrong

[hramakumar]

Bug Report

eBayUI Version: 2.0.0-2 and skin 7.0.0-5

Description

The position of the badge number is wrong when it comes with a button. it is expected to be towards right of the button but it is actually at the bottom of the button

Workaround

Screenshots

[hramakumar]

[redacted internal URL]

[ianmcburnie]

@hramakumar Which browser and OS? I'm not seeing this issue on the Skin site. So maybe the issue is in the coreui layer or test page.

[seangates]

@hramakumar We should not post internal eBay URLs in this repo or the Skin repo.

[hramakumar]

@ianmcburnie I see it in all devices and browsers. in test page

[hramakumar]

@seangates oh ok. got it.

[ianmcburnie]

@hramakumar After further investigation it appears you might be missing the following class on the test page: icon-btn--badged.

Try changing this:

<button aria-label="Menu (5000000000000 unread items)" type="button" class="icon-btn" data-ebayui="" data-widget="/@ebay/ebayui-core$2.0.0-2/dist/components/ebay-button/index" id="s0-0-16-4-426">..</button>

To this:

<button aria-label="Menu (5000000000000 unread items)" type="button" class="icon-btn icon-btn--badged" data-ebayui="" data-widget="/@ebay/ebayui-core$2.0.0-2/dist/components/ebay-button/index" id="s0-0-16-4-426">..</button>

Fixes it for me:

[seangates]

@ianmcburnie That should be added automatically by the button, though, right?

[seangates]

(And I realized this after I transferred it.)

[seangates]

We're missing some stuff that appears to have been caught in a bad merge/rebase: https://github.com/eBay/ebayui-core/pull/479/files#diff-f780e3139d3c687649c013136cdc9d0cR53

[ianmcburnie]

I'm going to transfer this back.

[seangates]

Yeah, apologies. 😞

[ianmcburnie]

@seangates Good spot regarding the missing code. Is there an easy way to figure out everything that's missing? This one should be our highest priority.

[seangates]

No easy way, other than going through the files line by line. Luckily, I know this code pretty well.

It also shows that we should be very careful when we're merging/rebasing and have conflicts. Blame shows it's my fault, and I'm happy to take that blame, but there might have been another action throughout which showed the issue.

[seangates]

Merged.

[ianmcburnie]

Fix verified in demo page and marketplace.