Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bogdan minor improvements - followup of #9 #10

Closed
wants to merge 17 commits into from
Closed

Bogdan minor improvements - followup of #9 #10

wants to merge 17 commits into from

Conversation

alexbumbacea
Copy link
Contributor

Bogdan minor improvements - followup of #9

Bogdan Rancichi and others added 17 commits December 14, 2016 00:19
@alexbumbacea
moved to a more standard symfony path
3d282b5
@alexbumbacea
removed old files locations
c735253
@alexbumbacea
saved autoloader in variable and unregister it on shutdown
665bfbf
@alexbumbacea
implement a prependextension to verify if you've put a existing and c…
63d26ed 
…orrect service (PSR6)
@alexbumbacea
get the name of the configuration tree from extension(good practice) …
af03bbe 
…and generate a configuration tree for configuring the bundle with various values
@alexbumbacea
removed class body
dc7e5ac
@alexbumbacea
completed the README with a more detailed explanation
49e66fd
@alexbumbacea
added some doc comments and removed some use statements
9eb36d4
@alexbumbacea
avoid colision when having a method with no parameter and the same ca…
9f41cec 
…che name(prefix)
@alexbumbacea
make more clear what cache is (the annotation object)
a90d459
@alexbumbacea
move generate class to concrete class instead of parent this is to av…
1339f9f 
…oid a bug that when you change a method signature you have to manually delete the cache in order to force re-creation
@alexbumbacea
small touch of removing extra spaces & un-used use statements
6f54618
@alexbumbacea
spaced out the doc comments
740add9
@alexbumbacea
small touches for doc comments spaces & remove unused statements
8acbeb1
@alexbumbacea
add return types (php7) and spaces out the doc comments
f3bd9f8
@alexbumbacea
make tests work again
b1e8887
@alexbumbacea
remove empty files
4b88ae8
@coveralls
Copy link

coveralls commented Dec 13, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 93.659% when pulling b1e8887 on alexbumbacea:bogdan-minor-improvements into 096f131 on eMAGTechLabs:master.

@coveralls
Copy link

coveralls commented Dec 13, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.3%) to 93.659% when pulling 4b88ae8 on alexbumbacea:bogdan-minor-improvements into 096f131 on eMAGTechLabs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbumbacea @coveralls