Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urlparse to urllib.parse for Python3 usage #24

Open
brockfansler opened this issue Jul 9, 2019 · 2 comments
Open

Update urlparse to urllib.parse for Python3 usage #24

brockfansler opened this issue Jul 9, 2019 · 2 comments

Comments

@brockfansler
Copy link

Had to update the import urlparse to import urllib.parse on line 13 along with:

Line 56: video_base_url = urllib.parse.urljoin(base_url, video['base_url'])
Line 94: audio_base_url = urllib.parse.urljoin(base_url, audio['base_url'])
Line 175: base_url = urllib.parse.urljoin(master_json_url, content['base_url'])

@chaoscreater
Copy link

My man!

@duberney
Copy link

Fixed on #27

NaanProphet added a commit to NaanProphet/vimeo-download that referenced this issue Feb 20, 2023
- applied the suggestions for urlparse from eMBee#24
- removing versions for requirements.txt as per guidance of eMBee#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants