Refactor/migration options to manifest v3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add options menu for extension * feat: Add options.html to manifest and storage permissions * fix: delete option without id error * feat: Update native client ff2mpv.py * feat: Update ff2mpv.js to allow multiple context menus * refactor: Remove logs * refactor: Add new line at end of file * feat: Update ruby client to support options * refactor: Reduce unnecessary function calls * refactor: Trim lines and prevent sending empty arguments * fix: Prevent access to dead objects * refactor: Remove uuid wrapper function * refactor: Improve css handling for light and dark theme * feat: Add warning message on top of options page * refactor: Expand control flow on save/update * refactor: Prevent unnecesary operations when deleting a new profile
…at were performed for arch arm64 (woodruffw#111)
* feat: Add onMessageExternal to allow external applications to communicate with ff2mpv * fix: Typo in console.warn function Co-authored-by: William Woodruff <william@yossarian.net> * refactor: Change log to debug Co-authored-by: William Woodruff <william@yossarian.net> --------- Co-authored-by: William Woodruff <william@yossarian.net>
* feat: Update context menu entry if no profiles * refactor: Define TITLE global variable
* fix: Prevent error when trying to remove context menu on launch * refactor: remove unnecessary backticks
eNV25
requested changes
Feb 3, 2024
There was a problem hiding this comment.
This looks good.
Can you rebase this on upstream just in case there are conflicts. You are more knowledgeable about options code than me.
Never mind, the multiple commit are OK.
…n-options-to-manifest-v3
…n-options-to-manifest-v3
DanSM-5
force-pushed
the
refactor/migration-options-to-manifest-v3
branch
from
c5d0e8f
to
63f0656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate MPV profiles to MV3 extension
Description
These changes allow the MPV profiles feature from the MV2 version of the extension to work with the changes for MV3
Main changes
chrome.runtime.sendMessageAPI instead ofchrome.extension.getBackgroundPage()Pending tasks (TODOs)
Tests
I tested the feature and it is working on Google Chrome v120.0.6099.225 for windows.