Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressbook computation algorithm change: Spec #338

Closed
chinuhub opened this issue Dec 6, 2018 · 15 comments
Closed

Addressbook computation algorithm change: Spec #338

chinuhub opened this issue Dec 6, 2018 · 15 comments

Comments

@chinuhub
Copy link
Contributor

chinuhub commented Dec 6, 2018

Provide a set of email addresses as trusted one.

  1. When processing a message:
    If sender is a trusted mail address-
    Call process contact with all name-email pairs (appearing anywhere in this message’s header) as trusted ones.
    if sender is not a trusted email address-
    Call process contact with all name-email pairs (appearing anywhere in this message’s header) as non-trusted ones.

If non-trusted name-email pair then don’t do unification based on name (but the unification based on email is still done). After that, just add the name in the contact.

If trusted name-email pair then perform the unification as done earlier.

Case 1.

Suppose we have two name-email pairs appearing in the archive.
Fikes notification@linkedin.com and Moore notification@linkedin.in

Earlier these two were being unified because of the common mail id. As a result, these two different names were being put in the same contact. It resulted in those names being in the same contact with proper names of Fikes like
Richard Fikes
Richard L. Fikes
Fikes
fikes@cs.stanford.edu.in

After the algorithm change, now there will be a new contact with email id as notification@linkedin.com and names of Fikes, Moore etc. being together in that contact.

** Case 2 **
[Not addressed in modified algorithm] if someone sends a mail to

Dummy fikes@cs.stanford.edu and fikes@cs.stanford.edu is a trusted email address:

If this mail was sent from a trusted name-email pair:
Then this association is a trusted one and unification will be based on ‘dummy’ as well as on email address.
If this mail was sent from a non-trusted name-email pair:
Then this association is non-trusted so no unification will take place based on "dummy" but unification will take place based on email. It results in "dummy" being added to the contact where fikes@cs.stanford.edu is a valid email address.

@peterchanws
Copy link
Contributor

Using Bush small and jeb@jeb.org initially, I got Jeb Bush listed in the correspondent list. However, after adding jeb@bush-brogan-2002 as trusted email address, Jeb Bush disappear from the correspondent list. Will continue testing with Fikes.

@peterchanws
Copy link
Contributor

peterchanws commented Dec 10, 2018

please see Chinmay's specifications

@chinuhub
Copy link
Contributor Author

For every correspondent, there will be 3 columns in total.

Messages sent, Messages received, Messages received from the owner

Message sent- number of messages where this correspondent is as a sender.
Messages received- number of messages where this correspondent is as a receiver (to,cc,bcc)
Messages received from the owner - If owner's mail id is given then the number of messages sent by owner's addresses where this correspondent appears as a receiver.

@peterchanws
Copy link
Contributor

peterchanws commented Jan 16, 2019

ver Jan 16
The 3 columns should apply to processing, discovery and delivery module as well as appraisal.
Done - Jan 17

@peterchanws
Copy link
Contributor

peterchanws commented Jan 17, 2019

Add "Archive owner email address" under "More". Although we can add this information in Edit Correspondent, our system (via browser) is not good at editing a big address book.

ADDED - Jan 20 version

@peterchanws
Copy link
Contributor

System somehow treats some email as correspondent name. Example:

brankel@eog.state.fl.us
Laura Branker
Branker, Laura
laura.branker@myflorida.com

@peterchanws
Copy link
Contributor

peterchanws commented Jan 17, 2019

It seems "Received messages" count messages "To" the designated correspondent/address. It should include "cc/bcc" as well.

@peterchanws
Copy link
Contributor

peterchanws commented Jan 17, 2019

Need to update Advance Search:
From:
Messages Direction: Incoming; Outgoing; Either
To:
Messages Sender: Archiver Owner _____

@peterchanws
Copy link
Contributor

peterchanws commented Jan 18, 2019

Need to update "Information about this archive"
from

Messages: 123
Incoming: 234
Outgoing: 345

Images: 234
Documents: 345
Others:456

to
Messages: 123
Images: 234
Documents: 345
Others:456

screen shot 2019-01-17 at 6 15 01 pm

@hangal
Copy link
Contributor

hangal commented Jan 18, 2019 via email

@peterchanws
Copy link
Contributor

peterchanws commented Jan 18, 2019

Or
Messages: 123
Sent by owner: 234
Received by owner: 345

@peterchanws
Copy link
Contributor

peterchanws commented Jan 18, 2019

Archive: Bush small

When I change archive owner from Jeb Bush to Laura Banker, message counts didn't reflect such change:
Owner Laura Banker
screen shot 2019-01-17 at 10 16 00 pm
Owner Jeb Bush
screen shot 2019-01-17 at 10 17 16 pm

@chinuhub
Copy link
Contributor Author

Did you make sure that the same mail id did not appear in more than on contact?

@peterchanws
Copy link
Contributor

@chinuhub Sorry. After further verification, message counts after changes in email owner are correct.

@peterchanws
Copy link
Contributor

feature added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants