feat: add support for contact object #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpbalmeida
force-pushed
the
add_contact_object
branch
2 times, most recently
from
10b91a6
to
3ac27c3
Compare
Closed
ozscheyge
reviewed
Oct 19, 2022
There was a problem hiding this comment.
Change lgtm! Thanks for the contribution and sorry for the late reply!
I tested the new code against the old tests to ensure the new property is really optional.
It would be nice, if you could update the example in the README to include a contact object:
https://github.com/ePages-de/restdocs-api-spec#openapi-301-1
mpbalmeida
force-pushed
the
add_contact_object
branch
from
331e55b
to
6c2c386
Compare
|
Sorry I have completely missed this message and forgot about it, until I need this feature again. I rebased the PR, and add a small example. Please check if it's ok. |
mpbalmeida
force-pushed
the
add_contact_object
branch
from
6c2c386
to
e58760f
Compare
mpbalmeida
force-pushed
the
add_contact_object
branch
from
e58760f
to
ddd57e7
Compare
ozscheyge
approved these changes
Apr 14, 2023
Kieun
pushed a commit
to Kieun/restdocs-api-spec
that referenced
this pull request
Nov 3, 2023
* feat: add support for contact object Closes ePages-de#88 * docs: add documentation on how to define contacts (cherry picked from commit 2842c43)
wodrobina
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Update version number in README * fix: better management of numbers in OpenApi3Generator (#202) Co-authored-by: Jordan GAZEAU <jordan.gazeau@soprabanking.com> * Add project status notice (#209) * Add project status notice * Add link to maintenance issue * Upgrade gradlew to 7.4.2 (#214) * Fix extracting standard scope claim in OAuth2 JWT (#218) fixes #217 This fixes does not break current implementation of treating scope claim as List<String> * Fix broken security definition reference from security requirement for OAuth2 (#220) Fixes #219 * Make classes in restdocs-api-spec modules visible (#223) Fixes #222 * Polish README.md (#227) (cherry picked from commit 213f9e4) * docs: update FieldDescriptors example (#232) * docs: update FieldDescriptors example * docs: add new symbol for java (cherry picked from commit 26cd0dd) * feat: add support for contact object (#208) * feat: add support for contact object Closes #88 * docs: add documentation on how to define contacts (cherry picked from commit 2842c43) * Tabs to spaces (cherry picked from commit 2f5d1e2) * Drop usage of TravisCI (#236) GH-235 (cherry picked from commit 0b5d511) * Add GitHub Actions and Sonar support (#237) GH-235 (cherry picked from commit ac1600f) * Increase MaxMetaspaceSize (cherry picked from commit 1688a77) * ci: fix publish script name (cherry picked from commit 47f2173) * ci: ignore samples for code coverage report (#239) (cherry picked from commit 4893605) * docs: update readme [skip ci] (#238) GH-235 (cherry picked from commit de0c1ab) * feat: apply field optional (#244) * feat: apply field optional * fix lint (cherry picked from commit 4c735ca) * Feat : apply optional is nullable (#245) * feat: apply optional is nullable * chore: refactoring * chore: remove needless * fix deprecated * fix for test (cherry picked from commit 2900374) * Feat : Schema reuse through subschema (#246) * feat : Input a name for the subschema * feat : Input a name for the subschema * feat : Make sub schema * fix: lint * fix: requested & Suggested (cherry picked from commit 437d7da) * Fix to get regexp properly from the pattern constraint (#247) (cherry picked from commit c631886) * Keep supporting 0.16.x train to support Spring Boot 2.7.x and cherry-pick the latest features and fixes. --------- Co-authored-by: Oliver Zscheyge <o.zscheyge@epages.com> Co-authored-by: Jojo <45284640+jgazeau@users.noreply.github.com> Co-authored-by: Jordan GAZEAU <jordan.gazeau@soprabanking.com> Co-authored-by: Jan Mewes <jan.mewes@ks-plus.org> Co-authored-by: Oliver <ozscheyge@users.noreply.github.com> Co-authored-by: Johnny Lim <izeye@naver.com> Co-authored-by: Taeyang Jin (Heli) <sun@dataportal.kr> Co-authored-by: Marcos Paulo Belasco de Almeida <me@marcosalmeida.dev> Co-authored-by: Jan Mewes <jan.mewes@epages.com> Co-authored-by: Xeroman.K <81915068+xeromank@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88