Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19762] Multicast PDP + TCP data use case #594

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[19762] Multicast PDP + TCP data use case #594

merged 4 commits into from
Nov 13, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 12, 2023 •
edited by cferreiragonz
Loading

This PR adds:

  • A tutorial for using TCP for data while still having auto discovery over multicast
  • A link to the previous use case within the large data use case
  • A troubleshooting section with an entry for large data

This PR can be tested by either modifying the Fast DDS HelloWorld example (for the C++ API), or by creating a couple of XML and load them on an unmodified Fast DDS HelloWorld example (for the XML API). Both have been tested to work in the same host, and also on different hosts using docker.

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@EduPonz
Refs #19762: Introduction
2f257b4 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #19762: TCP with multicast discovery
39073f6 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #19762: Add Troubleshooting section
0820330 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
cferreiragonz reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples work well. Just some minor suggestions.

docs/fastdds/use_cases/large_data/large_data.rst Outdated Show resolved Hide resolved
docs/fastdds/use_cases/large_data/large_data.rst Outdated Show resolved Hide resolved
docs/fastdds/use_cases/tcp/tcp_use_case.rst Outdated Show resolved Hide resolved
docs/fastdds/use_cases/tcp/tcp_with_multicast_discovery.rst Outdated Show resolved Hide resolved
@EduPonz
Refs #19762: Apply Carlos' suggestions
8b603fc 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
cferreiragonz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 89c199c into master Nov 13, 2023
4 checks passed
@EduPonz EduPonz deleted the documentation/large-data/tcp branch November 13, 2023 14:03
@cferreiragonz
Copy link
Contributor

@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Dec 11, 2023 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@EduPonz @mergify
Multicast PDP + TCP data use case (#594)
05bc1e0 
* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@EduPonz @mergify
Multicast PDP + TCP data use case (#594)
d0de4dd 
* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 11, 2023
@EduPonz @mergify
Multicast PDP + TCP data use case (#594)
6cb33fd 
* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)

# Conflicts:
#	code/XMLTester.xml
@mergify mergify bot mentioned this pull request Dec 11, 2023
Merged
EduPonz added a commit that referenced this pull request Dec 12, 2023
@mergify @EduPonz @cferreiragonz
Multicast PDP + TCP data use case (#594) (#610)
5b142e9 
* Multicast PDP + TCP data use case (#594)

* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)

# Conflicts:
#	code/XMLTester.xml

* Fix Conflicts

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz pushed a commit that referenced this pull request Dec 12, 2023
@mergify @EduPonz
Multicast PDP + TCP data use case (backport #594) (#608)
51dead6 
* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request Dec 12, 2023
@mergify @EduPonz
Multicast PDP + TCP data use case (#594) (#609)
2744dbe 
* Refs #19762: Introduction

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: TCP with multicast discovery

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Add Troubleshooting section

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #19762: Apply Carlos' suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 89c199c)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @cferreiragonz