Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19773] Rework log upon receiver resource creation failure #3954

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[19773] Rework log upon receiver resource creation failure #3954

merged 2 commits into from
Oct 24, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Oct 24, 2023 •
edited
Loading

Description

This reworks what was done on #3924, so

  1. The log is a warning instead of an error
  2. The log is not always shown, since there are places (unique network flows, for instance) where several calls to createReceiverResources are done, and an error log is shown when all of them fail.

@Mergifyio backport 2.11.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #19773. Turn log error into a log warning.
099d77e 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs #19773. Add boolean argument to createReceiverResources.
58e7271 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.12.1 milestone Oct 24, 2023
Mario-DL
Mario-DL approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Oct 24, 2023
@MiguelCompany
Copy link
Member Author

@Mergifyio backport 2.11.x 2.10.x 2.6.x

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2023 •
edited
Loading

backport 2.11.x 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 63c4150 into master Oct 24, 2023
12 of 14 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/log-warning-resource-creation branch October 24, 2023 15:22
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@MiguelCompany @mergify
Rework log upon receiver resource creation failure (#3954)
e47f14a 
* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 63c4150)
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@MiguelCompany @mergify
Rework log upon receiver resource creation failure (#3954)
adf3585 
* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 63c4150)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
This was referenced Oct 24, 2023
Merged
Closed
mergify bot pushed a commit that referenced this pull request Oct 24, 2023
@MiguelCompany @mergify
Rework log upon receiver resource creation failure (#3954)
f85c48e 
* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 63c4150)

# Conflicts:
#	src/cpp/rtps/participant/RTPSParticipantImpl.cpp
@mergify mergify bot mentioned this pull request Oct 24, 2023
Closed
@fujitatomoya fujitatomoya mentioned this pull request Oct 24, 2023
Closed
MiguelCompany added a commit that referenced this pull request Oct 25, 2023
@MiguelCompany
Rework log upon receiver resource creation failure (#3954)
f53ddb0 
* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany mentioned this pull request Oct 25, 2023
Merged
MiguelCompany added a commit that referenced this pull request Oct 25, 2023
@MiguelCompany
Rework log upon receiver resource creation failure (#3954)
eac084d 
* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany mentioned this pull request Oct 25, 2023
Merged
MiguelCompany added a commit that referenced this pull request Oct 26, 2023
@mergify @Mario-DL @MiguelCompany
Log warning message upon receiver resource creation failure (#3938)
be85b5e 
* Log error message upon receiver resource creation failure (#3924)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)

* Update src/cpp/rtps/participant/RTPSParticipantImpl.cpp

* Rework log upon receiver resource creation failure (#3954)

* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Oct 26, 2023
@mergify @Mario-DL @MiguelCompany
Log warning upon receiver resource creation failure (#3937)
54be56c 
* Log error message upon receiver resource creation failure (#3924)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 77a85dd)

* Rework log upon receiver resource creation failure (#3954)

* Refs #19773. Turn log error into a log warning.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

* Refs #19773. Add boolean argument to `createReceiverResources`.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL