[20652] Add DNS entries to hosts files on github workflows (backport #4776) #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #20652. Write hosts file on reusable-ubuntu-ci. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Write hosts file on reusable-sanitizers-ci. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Write hosts file on reusable-mac-ci. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20652. Apply review suggestions. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 625b041)
10 tasks
JesusPoderoso
approved these changes
May 20, 2024
|
@richiprosima please test linux please test windows |
|
CI issues are unrelated to PR |
JesusPoderoso
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows github workflow is writing the hosts file so the tests using DNS can be run.
This PR writes the
/etc/hostsfile usingsudo tee -aon Ubuntu, Sanitizers, and Mac workflows.@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
N/A The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4776 done by [Mergify](https://mergify.com).