Only add -wdouble-promotion if supported #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
|
Build status:
|
|
Please patch against |
pablogs9
requested changes
Jul 5, 2021
Older (really old) GCC versions don't support this flag, so check the version of the used compiler before adding it. Signed-off-by: gavanderhoorn <g.a.vanderhoorn@tudelft.nl>
|
I believe that should do it. |
|
Build status:
|
pablogs9
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
This is basically a duplicate of eProsima/Micro-CDR#65.
GCC
4.6.0is already really old, but the compiler I'm targetting is even older.The unconditional addition of
-wdouble-promotioncauses builds to fail so I patch this out locally.It would be great if this could be merged here, so I have one less patch to apply.
No functional changes to anything and modern compilers will still see
-Wdouble-promotionadded to the flags.Edit: link to the GCC 4.6.0 docs: Options to Request or Suppress Warnings, and the same page, but for GCC 4.5.4. The former has the option, the latter doesn't.