Add Fast DDS Waitsets to Vulcanexus Humble branch #13
Conversation
…#616) Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
…ith get_first_untaken_info Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
…READ Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_publisher_info.hpp
Outdated
Show resolved
Hide resolved
| @@ -102,12 +103,6 @@ __rmw_destroy_service( | |||
| show_previous_error(); | |||
| RMW_SET_ERROR_MSG("Fail in delete datareader"); | |||
| final_ret = RMW_RET_ERROR; | |||
| info->request_reader_->set_listener(nullptr); | |||
There was a problem hiding this comment.
Do not remove this line. In case that the DataReader deletion fails, the listener is detached from the DataReader so it can be deleted without having any conflict. Same comment applies below to the response_writer.
There was a problem hiding this comment.
response_writer listener is not set to nullptr in case that the deletion of the DataWriter fails. This could cause a core dump if the deleted listener is still attached to the DataWriter.
|
I suggest applying these suggestions to the original PR too. |
jsan-rt
force-pushed
the
feature/fastdds-waitsets-humble
branch
from
3aec19d
to
966891b
Compare
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
jsan-rt
force-pushed
the
feature/fastdds-waitsets-humble
branch
from
966891b
to
c31f2eb
Compare
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
…ents. Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
jsan-rt
force-pushed
the
feature/fastdds-waitsets-humble
branch
from
c31f2eb
to
aca2fae
Compare
There was a problem hiding this comment.
Changes LGTM!
Disclaimer: currently the following tests in rclcpp are failing. This is caused because ROS 2 assumes that every sample is notified when this is not necessarily required.
test_clienttest_servicetest_subscription
Due to the current implementation, notifying more samples than expected can lead to some overhead performance. Nevertheless, changes included in this PR are required to solve several other more important issues.
No description provided.