Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4454 case1 #464

Merged
merged 7 commits into from
Oct 1, 2023
Merged

Feature/4454 case1 #464

merged 7 commits into from
Oct 1, 2023

Conversation

cayop
Copy link
Collaborator

@cayop cayop commented Oct 1, 2023

Description

Compare device from one closed lot and the actual device

Fixes # (4454)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

Attention: 645 lines in your changes are missing coverage. Please review.

Comparison is base (5bcf3b2) 83.64% compared to head (50ec4ee) 79.96%.
Report is 1 commits behind head on testing.

Additional details and impacted files
@@             Coverage Diff             @@
##           testing     #464      +/-   ##
===========================================
- Coverage    83.64%   79.96%   -3.69%     
===========================================
  Files          122      123       +1     
  Lines        13685    14370     +685     
===========================================
+ Hits         11447    11491      +44     
- Misses        2238     2879     +641     
Files Coverage Δ
ereuse_devicehub/__init__.py 100.00% <100.00%> (ø)
ereuse_devicehub/resources/lot/models.py 87.70% <100.00%> (+0.42%) ⬆️
ereuse_devicehub/resources/documents/device_row.py 86.66% <60.00%> (ø)
ereuse_devicehub/inventory/views.py 79.42% <22.72%> (-2.44%) ⬇️
ereuse_devicehub/resources/device/models.py 80.53% <36.52%> (-4.89%) ⬇️
...evicehub/resources/documents/compare_device_row.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cayop cayop merged commit f42b2d0 into testing Oct 1, 2023
4 checks passed
@cayop cayop deleted the feature/4454-case1 branch October 1, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants