Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUBD-481 Improve MathJax detection regex, disable typesetting on page load #588

Merged
merged 4 commits into from
May 31, 2022
Merged

PUBD-481 Improve MathJax detection regex, disable typesetting on page load #588

merged 4 commits into from
May 31, 2022

Conversation

hardyoyo
Copy link
Contributor

@hardyoyo hardyoyo commented May 31, 2022 •
edited
Loading

@hardyoyo
PUBD-481 improve the mathjax detection regex
38dfcb4
@hardyoyo
PUBD-481 Disable MathJax typesetting on page load
7d68e36 
- Disable MathJax typesetting on first page load, via mathjaxConfig
- Makes Better-React-Mathjax behave the way it is documented to behave
- See fast-reflexes/better-react-mathjax#16
  for details
@hardyoyo
fix promoteVersion.sh
1ccd084
tingletech
tingletech approved these changes May 31, 2022
View reviewed changes
app/jsx/components/ArbitraryHTMLComp.jsx Outdated Show resolved Hide resolved
myucekul
myucekul reviewed May 31, 2022
View reviewed changes
Copy link
Collaborator

@myucekul myucekul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promote version change is not related to MathJax update.

@hardyoyo
Copy link
Contributor Author

Promote version change is not related to MathJax update.

This is correct, it's how I promoted the beanstalk app from dev to stg, though, so I figured I might as well throw it in here. I can remove it if you would prefer to keep this PR about MathJax.

@hardyoyo hardyoyo merged commit 5f65c15 into eScholarship:master May 31, 2022
@hardyoyo hardyoyo deleted the PUBD-481-improve-mathjax-detection-v2 branch May 31, 2022 19:57
@hardyoyo hardyoyo mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myucekul myucekul myucekul approved these changes

@tingletech tingletech tingletech approved these changes

@everreau everreau Awaiting requested review from everreau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardyoyo @tingletech @myucekul