Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for v1.3.0 according to contribution guidelines #104

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Conversation

bvreede
Copy link
Contributor

@bvreede bvreede commented Nov 30, 2021

Ready for new release.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #104 (cf9f8c2) into master (2240bc1) will increase coverage by 0.62%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   98.32%   98.94%   +0.62%     
==========================================
  Files           7        7              
  Lines         358      380      +22     
==========================================
+ Hits          352      376      +24     
+ Misses          6        4       -2     
Impacted Files Coverage Δ
era5cli/cli.py 98.03% <87.50%> (+1.16%) ⬆️
era5cli/__version__.py 100.00% <100.00%> (ø)
era5cli/fetch.py 99.45% <100.00%> (+0.65%) ⬆️
era5cli/inputref.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c062e...cf9f8c2. Read the comment docs.

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most changes look good to me, I just have a small nitpick see inline suggestions.

Also is geopotential/orograph change something worth mentioning in /README.md?

CITATION.cff Outdated Show resolved Hide resolved
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
@bvreede
Copy link
Contributor Author

bvreede commented Nov 30, 2021

Most changes look good to me, I just have a small nitpick see inline suggestions.

That is not a nitpick, that is a good catch of a complete misinterpretation on my side! Thanks :)

Also is geopotential/orograph change something worth mentioning in /README.md?

I'm on the fence. Decided against it because it doesn't add additional features, just makes era5cli compatible again with changes in CDS, and our readme is not very elaborate... but I can easily be persuaded :)

@bvreede bvreede merged commit db2f4ca into master Nov 30, 2021
@bvreede bvreede deleted the new_release branch November 30, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants